This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Remove double dots from cache path without keys #6552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we only care that the name has a position, not what is is, so don't waste resources looking it up
isset will return false if value is null which is not what we want. `array_key_exists` will still be faster than `array_search`
When no key is specified, do not concat the string with two dots as it results in a double dotted file path for both cache files.
|
Marking for 2.4 as this PR actually changes the cached config file path, which may be a problem in deployments happening towards 2.3.2 |
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
…ile-name' into develop Close #6552
|
Manually merged in Thanks @gabrielsch! |
gianarb
pushed a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
…s for newly introduced tests
gianarb
pushed a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
…ot-in-merged-config-cache-file-name' into develop Close zendframework/zendframework#6552
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #5165 from @juriansluiman that was closed by the lack of tests.
I only have added tests cases to this feature.