This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Http] Rationalize timeout behavior between adapters #6526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news here? |
|
@Ocramius Is there something which needs some updates? |
|
@egeloen nothing to add, I'll merge as-is. |
Ocramius
added a commit
that referenced
this pull request
Nov 19, 2014
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…rl-timeout-usage' into develop Close zendframework/zendframework#6526 Forward port zendframework/zendframework#6526
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
This PR rationalizes the timeout behavior across adapters. (curl only set timeout for connect whereas the socket sets it for connect/read timeout). Additionally,
CURLOPT_CONNECTTIMEOUT_MSandCURLOPT_TIMEOUT_MShas been introduced in curl 7.16.2, so if it is defined it is better to rely on them because they are more precise.