Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Refactor german (de) Zend_Validate.php #6481

Closed
wants to merge 10 commits into from
Closed

Conversation

fabwu
Copy link

@fabwu fabwu commented Jul 23, 2014

  • Corrected placeholder token '%' for some translations
  • Add new class names
  • Replace ' ' with " "

@ezimuel
Copy link
Contributor

ezimuel commented Aug 6, 2014

@Ocramius can you review that? Thanks.

@ezimuel ezimuel added this to the 2.4.0 milestone Aug 6, 2014
@Ocramius
Copy link
Member

Ocramius commented Aug 6, 2014

My german is not at a decent level. Re-assigning to @DASPRiD

"Invalid type given. String expected" => 'Ungültiger Eingabewert eingegeben. String erwartet',
"The input does not appear to be a valid Uri" => "Der Eingabewert scheint keine gültige Uri zu sein",
// Zend\I18n\Validator\Alnum
"Invalid type given. String, integer or float expected" => "Ungültiger Eingabewert eingegeben. String, Integer oder Float erwartet",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ungültiger Eingabewert eingegeben is duplicated ... Ungültiger Eingabewert is enough


// Zend\Validator\Sitemap\Priority
"The input is not a valid sitemap priority" => "Der Eingabewert ist keine gültige 'priority' für Sitemap",
"Invalid type given. Numeric string, integer or float expected" => "Ungültiger Eingabewert eingegeben. Nummerischer String, Integer oder Float erwartet",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ungültiger Eingabewert eingegeben is duplicated ... Ungültiger Eingabewert is enough

@marc-mabe
Copy link
Member

I'm not sure about the translation of input to Eingabewert. It sounds a bit odd in german.

@fabwu
Copy link
Author

fabwu commented Aug 16, 2014

I will implement this modifications as soon as possible. As a translation for input we can use a simple Eingabe

@fabwu
Copy link
Author

fabwu commented Sep 1, 2014

@marc-mabe what do you think about Eingabe as translation for Eingabewert?

@gkralik
Copy link
Contributor

gkralik commented Sep 2, 2014

Eingabe is fine.

@fabwu
Copy link
Author

fabwu commented Oct 14, 2014

@DASPRiD Could you review that, please?

Sorry the rebase went wrong a little bit...

@sandrokeil
Copy link
Contributor

@wuethrich44 There is a typo. Please replace wärend with während in translated text.

@Ocramius
Copy link
Member

@wuethrich44 I've merged this PR into develop at eae5b5e, thanks a lot!

Thanks to the reviewers as well :-)

@Ocramius Ocramius closed this Nov 19, 2014
weierophinney pushed a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants