This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Make AddressList logic more accessible #6268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @throws Exception\InvalidArgumentException | ||
| * @return AddressList | ||
| */ | ||
| public function addFromString($address) |
There was a problem hiding this comment.
Just an idea: can we move this to an external helper class instead?
There was a problem hiding this comment.
I'm not sure where a helper class would go?
There was a problem hiding this comment.
Not sure either :\ I guess it makes sense here then.
|
@davidwindell can you remove davidwindell/zf2@ef98f22 ? |
|
@davidwindell can you also move the relevant tests or copy them to the appropriate test class? |
|
@Ocramius errant commit has been removed, can we merge this now? The existing tests are specific to headers so probably best to leave them where they area. |
Ocramius
added a commit
that referenced
this pull request
Jul 27, 2014
|
@davidwindell merged manually @9c1130859d32f465cbc38a76d58211c2d3a31565 |
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…om-string' into develop Close zendframework/zendframework#6268
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed access to the logic used here outside of Zend\Mail\Header\x, so I moved it to the AddressList.