Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Add clearByPrefix to Redis Cache Storage #6252

Closed
wants to merge 1 commit into from

Conversation

vahid-sohrabloo
Copy link
Contributor

No description provided.

@vahid-sohrabloo
Copy link
Contributor Author

Why Travis Fail?
I give this error

PHP Warning:  require(PHP/CodeCoverage/Autoload.php): failed to open stream: No such file or directory in /home/travis/build/zendframework/zf2/vendor/sebastianbergmann/phpcov/src/autoload.php on line 44

@Ocramius
Copy link
Member

@vahid-sohrabloo don't bother too much about that - there is another problem at the top (trailing spaces)

@Ocramius
Copy link
Member

Could you also open the PR from a different branch next time? Also, is this PR's code already covered by the base test cases?

@marc-mabe
Copy link
Member

This PR looks good 👍

@Ocramius The method is covered already by CommonAdapterTest::testClearByPrefix*() but (I think) the redis adapter tests are disabled by default incl. travis

@Ocramius Ocramius self-assigned this Jul 28, 2014
@Ocramius Ocramius added this to the 2.4.0 milestone Jul 28, 2014
Ocramius added a commit that referenced this pull request Jul 28, 2014
@Ocramius
Copy link
Member

@marc-mabe @vahid-sohrabloo merged manually @4386d1b1bb3a7354b66fda246d17892e40171f7a, thank you!

@weierophinney
Copy link
Member

Closed with 4386d1b

gianarb pushed a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants