This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix unused imports and local variables #6093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,7 +127,7 @@ public function handleRouteNotFoundError(MvcEvent $e) | |||
| $mm = null; | |||
| try{ | |||
| $mm = $sm->get('ModuleManager'); | |||
| } catch (ServiceNotFoundException $e) { | |||
| } catch (ServiceNotFoundException $exception) { | |||
There was a problem hiding this comment.
Variable was renamed to prevent collision with the MvcEvent argument
|
Test added (Travis failure is unrelated) |
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-math
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-math
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-text
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-text
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-json
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-json
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-escaper
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-escaper
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
gianarb
pushed a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
…ups' into develop Close zendframework/zendframework#6093 Forward Port zendframework/zendframework#6093
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes unused use statements and removes unused local variables