This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix for #6012 - Use wrapper for substr() in ProgressBar #6019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moderndeveloperllc the fix seems correct, but a test is missing |
|
@moderndeveloperllc Works like a charm! |
* 'master' of https://github.com/moderndeveloperllc/zf2: Fix for #6012 - Use wrapper for substr() in ProgressBar
…o ConsoleStub as it was conflicting with the ProgressBar\Stub class
|
@Ocramius Two new tests added to verify truncation and padding working properly. I moved/renamed the Stub class out as ConsoleStub to avoid confusion with ProgressBar\Stub. |
|
@moderndeveloperllc because of the tree being messed up, I'm going to squash on merge here. |
|
@Ocramius Thanks. I thought I had my rebase right, but looks like I need to do better next time. |
|
Fixed in @dddceaa76520e2ab10a874941ffcd09e608bb002 and @29529fcb4d58b681a3bb352cba551362aa35358a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tburschka found the issue.