This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Added testcase for BlockCipher using 0 values #5902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested against 0 (integer), 0.0 (float), and '0' (string). All 3 values should be accepted
| @@ -149,6 +149,23 @@ public function testEncryptDecryptUsingBinary() | |||
| } | |||
| } | |||
|
|
|||
| public function testEncryptDecryptUsingZero() | |||
| { | |||
| $possibleValues = array(0, 0.0, '0'); | |||
There was a problem hiding this comment.
Please refactor this for use a data provider
weierophinney
added a commit
that referenced
this pull request
Mar 10, 2014
Added testcase for BlockCipher using 0 values
weierophinney
added a commit
that referenced
this pull request
Mar 10, 2014
- Changed test to use a data provider - Implemented a fix for the behavior demonstrated by the test
|
Merged to master with updates to the library that address the issue demonstrated in the tests. |
weierophinney
added a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
…ch-1 Added testcase for BlockCipher using 0 values
weierophinney
added a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
…ed in test - Changed test to use a data provider - Implemented a fix for the behavior demonstrated by the test
weierophinney
added a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against 0 (integer), 0.0 (float), and '0' (string). All 3 values should be accepted