Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fix for #5894 - .il Domain checking #5900

Closed
wants to merge 2 commits into from
Closed

Fix for #5894 - .il Domain checking #5900

wants to merge 2 commits into from

Conversation

moderndeveloperllc
Copy link
Contributor

Fix for Issue #5894

  • .il validation for Hebrew and Latin domain names;
  • Update validTLDs from IANA website;
  • Add a few more Cyrillic IDN checking strings from IANA website;
  • Use UTF8 string wrapper for strlen calls;
  • Clean up TLD checking (if we are using getTldCheck() == true we don't need any further checking of the TLD validity);
  • Add new tests for some of the new UTF-8 TLDs

There is more cleaning up to do in this class:

  • TLDs like .asia can take Chinese, Japanese, and Korean characters. Current logic only allows one file to be imported at a time.
  • Should probably have a idn_to_utf8() short-circuit in decodePunycode() for those with the intl extension.
  • Need to check the other new TLDs like .tokyo to see if they use IDN strings too

…s; update validTLDs from IANA website; Add a few more Cyrillic IDN checking strings from IANA website; Use UTF8 string wrapper for strlen calls; Clean up TLD checking (if we are using getTldCheck() == true we don't need any further checking of the TLD validity); Add new tests for some of the new UTF-8 TLDs
@moderndeveloperllc
Copy link
Contributor Author

Not sure why Travis failed. The unit tests I updated passed and there were no formatting issues.

@Ocramius
Copy link
Member

Ocramius commented Mar 4, 2014

@moderndeveloperllc the failure is not related with your issue

@weierophinney weierophinney added this to the 2.2.6 milestone Mar 5, 2014
weierophinney added a commit that referenced this pull request Mar 5, 2014
weierophinney added a commit that referenced this pull request Mar 5, 2014
@weierophinney weierophinney self-assigned this Mar 5, 2014
@moderndeveloperllc moderndeveloperllc deleted the feature/5894 branch March 5, 2014 15:51
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants