This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Optional ProxyManager in builds #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ocramius going to go ahead and merge... however, it'd be nice to be able to test this functionality via Travis-CI. Will you be keeping track in a branch to see when the issue resolves itself? |
weierophinney
added a commit
that referenced
this pull request
Mar 3, 2014
…in-builds Optional ProxyManager in builds
weierophinney
added a commit
that referenced
this pull request
Mar 3, 2014
|
@weierophinney it works locally, but I couldn't get it to run on travis for whatever reason :-( If there are changes in related functionality, I'll have to run the tests manually myself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer+Proxy-manager causing cyclic dependency resolutions has been a nightmare so far
Fortunately, the tests were already designed to skip tests when the ProxyManager is not installed, so this PR is trivial.