This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixes #4993 #5868
Closed
Fixes #4993 #5868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@froschdesign DocBlocks added, thanks ;) |
|
@froschdesign done ;). fixed; |
| @@ -65,8 +66,10 @@ public function addFeatures(array $features) | |||
|
|
|||
| public function addFeature(AbstractFeature $feature) | |||
| { | |||
| if (!$feature->getTableGateway() instanceof TableGatewayInterface && $this->tableGateway instanceof TableGatewayInterface) { | |||
There was a problem hiding this comment.
Features are a feature of AbstractTable's not TableInterfaces, so no need to check for TableGatewayInterface. Additionally, AbstractFeature objects are already AbstractTableGateways themselves (so they can share object state without having a public API with the actual TableGateway object). So I don't think this check is needed here.
|
@ralphschindler fixed. please let me know if I missed something ;) |
|
@ralphschindler |
|
@ralphschindler Can you update this with a milestone, please? |
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4993