Deprecate Proxy auto-generation #5858
Conversation
…es` (since the latter is deprecated)
| 'class_map' => array('foo' => __CLASS__), | ||
| 'proxies_namespace' => $namespace, | ||
| 'write_proxy_files' => true, | ||
| 'auto_generate_proxies' => true, |
There was a problem hiding this comment.
No, otherwise it would fallback to the eval() logic (and not write the file to disk). I probably need to fix the test method or see if it is not redundant
There was a problem hiding this comment.
Yes, the test is redundant, as well as the config flag. Simply dropping them
|
@Ocramius Please review the travis report. There is some problem with composer dependencies |
|
Saw that - cannot really fix as it seems, since it doesn't consider the dev branch of zf a 2.* (required by proxy-manager). I will diff the composer.json first |
|
@Maks3w yes, verified. This PR can't have green on travis because the This will get green once merged, the subtree split happened, and packagist updated its internal definitions |
Deprecate Proxy auto-generation. Close #5198
| @@ -51,22 +55,7 @@ public function createService(ServiceLocatorInterface $serviceLocator) | |||
| $factoryConfig->setGeneratorStrategy(new EvaluatingGeneratorStrategy()); | |||
| } | |||
|
|
|||
| if (isset($lazyServices['auto_generate_proxies'])) { | |||
There was a problem hiding this comment.
Some options seems to be gone. Can you update the doc ?
…fix/proxy-auto-generation Deprecate Proxy auto-generation. Close zendframework/zendframework#5198
Supersedes #5198
Ping @blanchonvincent