This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Avoid function usage in loops #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it doesn't make sense, see http://3v4l.org/Iu9gv#v500 and PR that I've created before #4923 that closed :p |
|
I'm not sure that we speak exactly the same thing. Currently, in these cases, the number of items is calculated in each iteration. This could simply be done once before the execution of the loop and therefore improve performance. |
|
ok ;) |
|
+1, can be merged! |
ghost
assigned
Maks3w
added a commit
that referenced
this pull request
Feb 18, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 18, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 18, 2014
gianarb
pushed a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the previous pull request #5815.