This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixes default type == string #5375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2013 23:30
See ZF1 issue for more: zendframework/zf1#229
See ZF1 issue for more: zendframework/zf1#229
| '<value><i4>8</i4></value>'. | ||
| '<value>a</value>'. | ||
| '<value>false</value>'. | ||
| '</data></array></value>', Zend_XmlRpc_Value::XML_STRING |
There was a problem hiding this comment.
there is no class using underscore in ZF2. use :
AbstractValue::getXmlRpcValue
instead. and use
AbstractValue::XML_STRING
instead. already at use statement : https://github.com/volftomas/zf2/blob/d645eb295cd99626b170f60a329321acd11419ba/tests/ZendTest/XmlRpc/ValueTest.php#L14
|
Uff, to much time in ZF1. Fixed. |
|
travis failure because of trailing_spaces , you can do : |
|
@volftomas I'm also seeing three new failures after this patch starting with PHP versions 5.4 and up; you can see representative failures starting here: https://travis-ci.org/zendframework/zf2/jobs/13182132#L966 |
|
@samsonasik don't know where to get this fixer but I removed the ones that I found. @weierophinney Now it should pass tests. |
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2013
Fixes default type == string
ghost
assigned
weierophinney
added a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
…tch-1 Fixes default type == string
weierophinney
added a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ZF1 issue for more: zendframework/zf1#229