This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Deprecate ProvidesEvents trait #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trait was added before we had a naming convention for traits, and has since been replaced by EventManagerAwareTrait. To help people understand this, we should have the actual code in the correct trait, and proxy the old one to the new one with a comment explaining what's going on.
| * A trait for objects that provide events | ||
| * NOTE: THIS TRAIT IS DEPRECATED! Please use EventManagerAwareTrait instead. | ||
| * This trait exists solely for backwards compatibility in the 2.x branch and | ||
| * willl likely be removed in 3.x. |
|
Review end. |
| @@ -12,55 +12,11 @@ | |||
| use Traversable; | |||
|
Should we add a |
|
@marc-mabe if so, I'd say maybe not until 2.3, but that's just a gut feeling. |
|
@EvanDotPro @marc-mabe I agree that we should throw the E_USER_DEPRECATED in this sense. |
|
Add the E_USER_DEPRECATED call here, and target for 2.3.0, please. |
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
Deprecate ProvidesEvents trait
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
ghost
assigned
|
I added the |
weierophinney
added a commit
to zendframework/zend-eventmanager
that referenced
this pull request
May 15, 2015
…eature/deprecate-old-traits Deprecate ProvidesEvents trait
weierophinney
added a commit
to zendframework/zend-eventmanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-eventmanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trait was added before we had a naming convention for traits, and
has since been replaced by EventManagerAwareTrait. To help people
understand this, we should have the actual code in the correct trait,
and proxy the old one to the new one with a comment explaining what's
going on.
I also improved the docblocks a little bit while I was in there.