Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Zend\Navigation - add to AbstractPage static factories #5136

Merged
merged 1 commit into from
Oct 23, 2013
Merged

Zend\Navigation - add to AbstractPage static factories #5136

merged 1 commit into from
Oct 23, 2013

Conversation

turrsis
Copy link
Contributor

@turrsis turrsis commented Sep 18, 2013

sometime use 'type' in $options not always possible

@samsonasik
Copy link
Contributor

travis failed because of trailing_spaces, please fix the trailing_spaces, you can use php-cs-fixer and run :

php php-cs-fixer.phar fix /path/to/dir --fixers=trailing_spaces

@froschdesign
Copy link
Member

@turrsis
Please add DocBlocks to all properties and methods.

@turrsis
Copy link
Contributor Author

turrsis commented Sep 19, 2013

php-cs-fixer.phar is not worked on Windows :(

@samsonasik
Copy link
Contributor

it is ok now 👍

@ghost ghost assigned weierophinney Oct 23, 2013
weierophinney added a commit that referenced this pull request Oct 23, 2013
…actory

Zend\Navigation - add to AbstractPage static factories
weierophinney added a commit that referenced this pull request Oct 23, 2013
@weierophinney weierophinney merged commit 4cb8a40 into zendframework:develop Oct 23, 2013
@turrsis turrsis deleted the hotfix/navigation-page-static-factory branch October 23, 2013 17:44
weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
…ix/navigation-page-static-factory

Zend\Navigation - add to AbstractPage static factories
weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants