Added metadata for oracle #5032
Conversation
See issue #3956
| /** | ||
| * Constraint type | ||
| * | ||
| * @param string $type |
There was a problem hiding this comment.
Sorry, but this isn't listed in the coding standards: http://framework.zend.com/wiki/display/ZFDEV2/Coding+Standards
Or did I miss it?
[edit: corrected url]
There was a problem hiding this comment.
yes, but it just for consistency with >6000 files other.
There was a problem hiding this comment.
I'm sorry, but there are more important things than an additional whitespace after an annotation tag I guess. The time of the people that are comitting is valuable and most of them don't get paid for their effort. I'd rather like to see their resources spend in improving the frameworks code instead of changing unimportant stuff which is not even worth to be mentioned in the coding standards ...
No offense, but this looks a bit pedantic to me.
There was a problem hiding this comment.
@tux-rampage we're all on the same boat. Making the framework better and trying to respect any possible aesthetic betterment is perfectly ok.
@samsonasik is ALSO putting his own free unpaid time into this. You are free to skip the CS comments if you think so, but please don't tell reviewers to not review, since they also put a lot of effort in it ;)
There was a problem hiding this comment.
@samsonasik
Sorry, but I have to agree with @tux-rampage. This is not defined in the coding standards.
And if I look at the Zend\Db\Sql\Ddl classes (only one example), it is not fair to make these hard requirements.
Please do not get me wrong, I want the same: a better framework and a good documentation (incl. DocBlocks). But the additional whitespace is not in the coding standards.
There was a problem hiding this comment.
@Ocramius I don't complain about the review, which is highly encouraged and thanks for doing so. But complaining about a missing white space, which is not even required by CS, is imho a bit too much.
There was a problem hiding this comment.
@tux-rampage @froschdesign it's up to you to agree with me or not. I just make a suggestion for consistencies. It not be a problem for me if it merged without my change suggestion :).
There was a problem hiding this comment.
@samsonasik Thanks for clarification. It sounded a lot like a must have requirement.
|
Could we merge this into the development tree? |
|
Yep, I've been working through the DB pull requests, and this one is on my list. I should be able to get to the Oracle specific ones today. |
|
cool, thanks. 👍 |
This commit adds a metadata source for Oracle as requested in #3956
This is missing the code for resolving triggers at the moment, but it's better than having no metadata source at all.
I've not been able to implement a Test case, yet.
It would be great if someone could tackle the missing items due to the lack of time from my side.