This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Adding missing "NOT IN" predicate #4781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "NOT IN" predicate.
|
@sebastien-gallet first sorry for late response, but it seems that this PR was overseen. If you want this PR still to be merged, you have to provide unittests, as this is required. |
provide adequate test unit for the "not in" predicate.
|
No worries. I added the unit test. Let me know if there is anything else. Thanks. |
|
@ralphschindler can u take a look on this? |
|
👍 Looks good to me. I'll wait for @ralphschindler's stamp of approval before merging though. |
|
Even while small, I think this is meant for the develop branch. |
ralphschindler
pushed a commit
that referenced
this pull request
Nov 18, 2013
ralphschindler
pushed a commit
that referenced
this pull request
Nov 18, 2013
Merge branch 'sebastien-gallet-master' into develop * sebastien-gallet-master: test the "not in" predicate Update Predicate.php
|
Merged to develop. |
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "NOT IN" predicate.
Can be used while chaining where expressions:
->where->notIn(..., ...)