Add maxLength to ParameterContainer

[postalservice14]

The Oci8/Statement class currently sets the max length parameter of oci_bind_by_name to -1. I need to be able to manually set this parameter.

This is my approach to doing this.

[ralphschindler]

This is a tough one for me. I really intended that kind of data to travel in errata, but the primary implementation is for passing additional type hints. Let me chew on this and see if I can make a suggestion that doesn't involve creating an API inside ParameterContainer that (logistically speaking) will only ever be used by Oracle drivers.

[postalservice14]

Yeah, totally understand. I can't remember now why I didn't use errata, but I thought there was a reason. I can look into it again too, when i have a second.

[ralphschindler]

Did you have any ideas here or want me to attempt to work something up in the coming days?

[postalservice14]

Sorry, been a busy week/holiday weekend. :-)

I started looking into it and now it's all coming back to me. Here are the reasons why I couldn't (and shouldn't IMO) use errata:

1. I couldn't use errata, because you can only store one piece of errata data per parameter. So if I were to use errata, I wouldn't be able to use it for anything else.
2. Errata, to me, means an error, and this really isn't an error case.
3. I needed to be able to set a maxLength on a per parameter basis.

So after looking it over, I still stand by my changes. I'm totally open to suggestions, and would love to see what you come up with, but I'm thinking this is the best way to handle this particular problem.

Thanks!

[mwillbanks]

@ralphschindler any thoughts here?

[Ocramius]

Requires a rebase

[postalservice14]

Pulled in master.

[adamlundrigan]

There is no test case covering this change to offsetSet

[postalservice14]

Good catch, tests have been updated.

[adamlundrigan]

@ralphschindler how do you feel about this one now that some time has passed?

[weierophinney]

Merged to develop for release with 2.4.0