Zend code doesn't generate heredoc correctly

[Danack]

require_once('../vendor/autoload.php');

}

Hi,

When code includes a heredoc block, the code generator doesn't respect the fact that the end of the heredoc needs to be at the start of a line. e.g.

use Weaver\ExtendWeaveInfo;
use Weaver\MethodBinding;
use Weaver\ImplementsWeaveInfo;

use Zend\Code\Reflection\ClassReflection;
use Zend\Code\Generator\ClassGenerator;

use Zend\Code\Generator\MethodGenerator;

class SomeClass {

    function someFunction() {

        $output = <<< END

        Fix it, fix it!
        Fix it, fix it!
        Fix it, fix it!
END;

    }
}

$reflector = new ClassReflection('SomeClass');
$classGenerator = new ClassGenerator();
$methods = $reflector->getMethods();
$classGenerator->setName("OutputClass");

foreach ($methods as $method) {
    $methodGenerator = MethodGenerator::fromReflection($method);

    $classGenerator->addMethodFromGenerator($methodGenerator);
}

$text = $classGenerator->generate();

echo $text;

generates:

class OutputClass
{

    public function someFunction()
    {
        $output = <<< END

                Fix it, fix it!
                Fix it, fix it!
                Fix it, fix it!
        END;
    }


}

The generated heredoc block is not valid, as it needs to be at the start of the line.

[Ocramius]

Seems like it also broke the string indentation...

[steverhoades]

See pull request #6283 for a fix.

[steverhoades]

@Ocramius can you be more specific as to the string indentation break? I'm happy to look at it.

[Ocramius]

See the diff:

        $output = <<< END

        Fix it, fix it!
        Fix it, fix it!
        Fix it, fix it!
END;

vs

        $output = <<< END

                Fix it, fix it!
                Fix it, fix it!
                Fix it, fix it!
        END;

[Danack]

Just to confirm, I tested this against head, and it does appear to be valid issue.

[Ocramius]

Handled in #6283