This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow the 'gc_probability' option to be set to zero. #4608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is valid because PHP divides gc_divisor into gc_probability - it would only be invalid to set gc_divisor to 0 (divide-by-zero), so this commit leaves the same test for that option alone.
|
It's my understanding that this is the "PHP way" of disabling session garbage collection which is really what I'm trying to do - so if there's a "ZF2 way" I missed I'll happily close this. |
ghost
assigned 
|
@Gwis nope, this is perfect -- the session configuration is meant to proxy to PHP's session INI settings! :) |
weierophinney
added a commit
that referenced
this pull request
Jun 11, 2013
Allow the 'gc_probability' option to be set to zero.
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…ero-gc-probability Allow the 'gc_probability' option to be set to zero.
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is valid because PHP divides gc_divisor into gc_probability - it would only
be invalid to set gc_divisor to 0 (divide-by-zero), so this commit leaves the
same test for that option alone.