This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Update StrategyInterface.php #4539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is to implement functionality as detailed in the AbstractHydrator. This should *not* be a BC break. https://github.com/zendframework/zf2/blob/master/library/Zend/Stdlib/Hydrator/AbstractHydrator.php#L114 https://github.com/zendframework/zf2/blob/master/library/Zend/Stdlib/Hydrator/AbstractHydrator.php#L131
|
You don't have to specify the optional object so this PR is not required (but for brevity may want to be merged). |
|
PHP considers optional arguments on an interface a part of the contract -- and thus any implementations need to define the optional argument as well, or else they will break the contract, and PHP will raise an error. As such, it is a BC break. Just note the optional parameter as an annotation. |
added 2 commits
May 24, 2013 11:37
Added todo for version 3.0.
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
May 24, 2013
Update StrategyInterface.php
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…ch-2 Update StrategyInterface.php
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to implement functionality as detailed in the AbstractHydrator. This should not be a BC break.
https://github.com/zendframework/zf2/blob/master/library/Zend/Stdlib/Hydrator/AbstractHydrator.php#L114
https://github.com/zendframework/zf2/blob/master/library/Zend/Stdlib/Hydrator/AbstractHydrator.php#L131