This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Update PhpDoc comment #4518
Closed
Update PhpDoc comment #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -213,7 +213,7 @@ public function isValid($value, $file = null) | |||
| * | |||
| * @param string $file | |||
| * @param string $errorType | |||
| * @return false | |||
| * @return bool | |||
There was a problem hiding this comment.
false is a valid phpDoc return type (see the phpDocumentor manual). bool would be misleading, as the method will never return true.
There was a problem hiding this comment.
While bool is more generic, it is accurate enough, though.
There was a problem hiding this comment.
It's not "accurate enough", though. It doesn't return either boolean, only false.
ghost
assigned 
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…otfix/update-php-doc-comment Update PhpDoc comment
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst looking at the code of
Filter\UploadandFilter\UploadFileto see what they are about, PhpStorm complained.