This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Class methods hydrator skips getters with optional parameters #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meters/no paremeters
Fixes test @b47c85e045b185cec8fd6b95b6db2d3d4ddf2a5c
|
Travis failed because of some filesystem tests |
| */ | ||
| public function filter($property) | ||
| { | ||
| try { |
There was a problem hiding this comment.
In theory, this result could be cached in a private static property since the result depends only on reflection.
There was a problem hiding this comment.
So... do you want me to wait to merge until you've done that improvement as well?
There was a problem hiding this comment.
Will do it tomorrow then - otherwise fine? :)
There was a problem hiding this comment.
Overall, looks good! I think caching the value makes sense, though, and would like to see that in.
| @@ -30,6 +30,11 @@ class ClassMethods extends AbstractHydrator implements HydratorOptionsInterface | |||
| protected $underscoreSeparatedKeys = true; | |||
|
|
|||
| /** | |||
| * @var \Zend\Stdlib\Hydrator\Filter\FilterInterface | |||
| */ | |||
| private $callableMethodFilter; | |||
ghost
assigned 
weierophinney
added a commit
that referenced
this pull request
May 24, 2013
…optional-parameters Class methods hydrator skips getters with optional parameters
weierophinney
added a commit
that referenced
this pull request
May 24, 2013
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…fix/class-methods-hydrator-optional-parameters Class methods hydrator skips getters with optional parameters
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Zend\Stdlib\Hydrator\ClassMethodsskips getters likegetFoo($bar = null)as they have>0parameters.This hotfix allows to call those methods as long as all parameters are optional.