This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[WIP] Fix for PHP 5.5 unit tests (and XDebug >= 2.2.0) #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On investigation, discovered XDebug 2.2 altered how xdebug_get_headers() works, which breaks unit tests for the abstract response sender. Added in some xdebug version sniffing in order to alter the tests accordingly.
- and into the system temp directory. This may fix the issue seen on Travis; regardless, it's good policy.
|
8ea14aa may address the Travis issues in 5.5; if it doesn't, I'm not sure what to do other than to disable those tests in 5.5. |
- Appears to be an issue with filesystem write privileges, but no way to track it down.
|
Ended up having to disable the tests on Travis. I can confirm they pass fine on 5.5.0RC1 and 5.5.0beta4 builds locally, which indicates to me an environment issue. |
|
Can I have somebody on @zendframework/community-review-team review, please? |
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issues observed with unit tests on PHP 5.5. One differentiating factor observed is a behavior change in XDebug 2.2.0 --
xdebug_get_headersno longer resets itself between calls. As such, response sender tests need to alter expectations based on the XDebug version detected.Travis is also still showing errors in the Zend\Filter\Compress\Zip tests, which unfortunately I cannot reproduce locally. I'm considering disabling these tests when in Travis.