This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Move Identity closure to separate factory #4155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxnuf
commented
Mar 31, 2013
maxnuf
commented
- Move Identity Controller Plugin to factory
- Move Identity View Helper to factory
* Move Identity Controller Plugin to factory * Move Identity View Helper to factory
| * @var array | ||
| */ | ||
| protected $factories = array( | ||
| 'identity' => 'Zend\Mvc\Controller\Plugin\Service\IdentityFactory', |
There was a problem hiding this comment.
You can leave just one space here, just align when in the same array.
It was only calling the parent constructor
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Apr 12, 2013
Move Identity closure to separate factory
weierophinney
added a commit
that referenced
this pull request
Apr 12, 2013
|
Since this introduces a new class (the factory), I've merged it against develop for release with 2.2.0. Thanks -- this will make it far easier to override what service is used for the helper/plugin! |
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…re/refactor-identity-helper Move Identity closure to separate factory
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.