Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Allow HTML5 doctype to use metaproperty #2037

Merged
merged 2 commits into from
Jul 30, 2012

Conversation

bakura10
Copy link
Contributor

It was not possible to use the "appendProperty/prependProperty" (used for Facebook open graph for instance) because <meta property was only allowed for doctype implementing RDFa. However, it looks like HTML5 doctype implicitely allow this usage (http://www.w3.org/TR/rdfa-in-html/)

@travisbot
Copy link

This pull request fails (merged ab0e764 into 8c4328f).

@travisbot
Copy link

This pull request passes (merged 2f83bfa into 8c4328f).

Helper\Doctype::HTML4_STRICT,
Helper\Doctype::HTML4_LOOSE,
Helper\Doctype::HTML4_FRAMESET,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, don't in this PR, leave trailing commas in array elements

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maks3w clarification: array definitions should include a comma on the last element.

@bakura10 This is a best-practice, as it eliminates errors on copy-and-paste, and also ensures that the diffs are smaller (one less line change, basically).

weierophinney added a commit that referenced this pull request Jul 30, 2012
- Added comma after last array element
@weierophinney weierophinney merged commit 2f83bfa into zendframework:master Jul 30, 2012
weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015
- Added comma after last array element
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants