Merge branch 'macnibblet/hotfix/feed-strategy'

PR zendframework/zendframework#1741
zendframework · Jul 4, 2012 · a2eb795 · a2eb795
2 parents 851904c + fd2a195
commit a2eb795
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 4 deletions.
diff --git a/src/Model/FeedModel.php b/src/Model/FeedModel.php
@@ -45,6 +45,16 @@ class FeedModel extends ViewModel
      */
     protected $type = false;
 
+    /**
+     * A feed is always terminal
+     *
+     * @var bool
+     */
+    protected $terminate = true;
+
+    /**
+     * @return \Zend\Feed\Writer\Feed
+     */
     public function getFeed()
     {
         if ($this->feed instanceof Feed) {
@@ -67,8 +77,8 @@ public function getFeed()
 
     /**
      * Set the feed object
-     * 
-     * @param  Feed $feed 
+     *
+     * @param  Feed $feed
      * @return FeedModel
      */
     public function setFeed(Feed $feed)
@@ -79,7 +89,7 @@ public function setFeed(Feed $feed)
 
     /**
      * Get the feed type
-     * 
+     *
      * @return false|string
      */
     public function getFeedType()

diff --git a/src/Strategy/FeedStrategy.php b/src/Strategy/FeedStrategy.php
@@ -162,10 +162,20 @@ public function injectResponse(ViewEvent $e)
                   ? 'application/rss+xml'
                   : 'application/atom+xml';
 
+        $model   = $e->getModel();
+        $charset = '';
+
+        if ($model instanceof Model\FeedModel) {
+
+            $feed = $model->getFeed();
+
+            $charset = '; charset=' . $feed->getEncoding() . ';';
+        }
+
         // Populate response
         $response = $e->getResponse();
         $response->setContent($result);
         $headers = $response->getHeaders();
-        $headers->addHeaderLine('content-type', $feedType);
+        $headers->addHeaderLine('content-type', $feedType . $charset);
     }
 }