Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add emoji picker icons #59

Merged
merged 2 commits into from
Feb 12, 2019
Merged

feat: add emoji picker icons #59

merged 2 commits into from
Feb 12, 2019

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Feb 11, 2019

  • BREAKING CHANGE?

Description

Add the following 12 and 16px icons:

  • basketball-fill/stroke
  • car-fill/stroke
  • cutlery-fill/stroke
  • leaf-fill/stroke
  • lightbulb-fill/stroke

Detail

Demo pages pre-published for review:
https://garden.zendesk.com/svg-icons/12px/
https://garden.zendesk.com/svg-icons/16px/

Checklist

  • 👌 SVG updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 SVG demo is up-to-date (yarn start)
  • ◾ Renders as expected in "dark" mode
  • ⬜ Renders as expected @ 2x scale

@allisonacs
Copy link

@jzempel what do you think about the name cutlery-? I'm a bit concerned that people are going to be more likely to search for something like fork-knife-.

Copy link

@allisonacs allisonacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ginnywood in all our focusing on the cutlery icon, I never took a close enough look at the leaf. Although it renders ok in Sketch, the stroke versions of leaf (both 12 and 16) feel odd with their strictly triangular points, particularly when rendered on a 1x screen:

image

Wondering if we can soften that corner a bit?

@jzempel
Copy link
Member Author

jzempel commented Feb 12, 2019

@allisonacs demo pages are now re-published for review with the updated leaf icons.

@jzempel jzempel merged commit 5f83f32 into master Feb 12, 2019
@jzempel jzempel deleted the jzempel/emoji-icons branch February 12, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants