Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Sparkle icons #332

Merged
merged 3 commits into from
Apr 17, 2024
Merged

feat: add Sparkle icons #332

merged 3 commits into from
Apr 17, 2024

Conversation

ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Apr 12, 2024 •
edited
Loading

Description

  • Adds Sparkle icons
  • Runs icons through optimization script

Screen Shot 2024-04-15 at 6 44 49 AM

Checklist

  • 👌 SVG updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 SVG demo is up-to-date (npm start)
  • ◾ Renders as expected in "dark" mode
  • ⬜ Renders as expected @ 2x scale

@ze-flo ze-flo requested a review from a team as a code owner April 12, 2024 21:54
@ze-flo ze-flo requested a review from steue April 12, 2024 22:00
jzempel
jzempel requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG source looks really nice-n-clean here. Let's remove ai- from all the file naming. The guidance for Garden icon nomenclature is to name what they are, not what they do. Design offers a downstream semantic mapping.

steue
steue suggested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@steue steue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second JZ's comment on the file naming, but LGTM!

@ze-flo ze-flo changed the title feat: add AI Sparkle icons feat: add Sparkle icons Apr 15, 2024
steue
steue approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@steue steue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the speedy work!

@ze-flo ze-flo merged commit fd9e88a into main Apr 17, 2024
3 checks passed
@ze-flo ze-flo deleted the ze-flo/ai-sparkle-icons branch April 17, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@steue steue steue approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ze-flo @jzempel @steue @zendesk-garden