feat: added camera icons and fixed formatting errors #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mike Tobia <[email protected]>
Francois-Esquire
approved these changes
Apr 6, 2022
jzempel
requested changes
Apr 6, 2022
There was a problem hiding this comment.
it would be good to eek out a bit of cost savings on the size by combining path elements into one. lmk if you'd like me to make these optimizations. Also, the fill="currentColor" attribute belongs on the path rather than the svg. See https://github.com/zendeskgarden/svg-icons/edit/main/src/16/123-fill.svg for comparison.
.gitignore
Outdated
| @@ -3,4 +3,4 @@ demo | |||
| dist | |||
| node_modules | |||
| package-lock.json | |||
| *.log | |||
| *.log | |||
There was a problem hiding this comment.
[nit] can we restore the newline at the end of this file? (ideally, it won't appear in the diff)
|
@jzempel if it's not too much trouble for you to make the reformatting changes, I will take you up on your offer! It's probably faster than me trying to figure it out :) |
jzempel
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added 16px and 12px stroke and fill versions of the camera icon
Detail
Checklist
designer as a reviewer)
yarn start)