Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update terminal icons to paths #212

Merged
merged 1 commit into from
Feb 23, 2021
Merged

fix: update terminal icons to paths #212

merged 1 commit into from
Feb 23, 2021

Conversation

steue
Copy link
Contributor

@steue steue commented Feb 23, 2021

  • BREAKING CHANGE?

Description

Fixes 8 icons to use all paths instead of strokes to prevent broken rendering when used in certain components.

12px and 16px versions of:

  • terminal-cli-stroke
  • terminal-cli-fill
  • terminal-window-stroke
  • terminal-window-fill

Detail

Checklist

  • 👌 SVG updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 SVG demo is up-to-date (yarn start)
  • ◾ Renders as expected in "dark" mode
  • ⬜ Renders as expected @ 2x scale

@steue steue requested a review from a team as a code owner February 23, 2021 00:45
@zendesk-garden zendesk-garden temporarily deployed to staging February 23, 2021 00:48 Inactive
m-lai
m-lai approved these changes Feb 23, 2021
View reviewed changes
Copy link

@m-lai m-lai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🙏🙏

@jzempel jzempel merged commit 5c8d938 into main Feb 23, 2021
@jzempel jzempel deleted the steue/terminal-paths branch February 23, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@m-lai m-lai m-lai approved these changes

@austingreendev austingreendev Awaiting requested review from austingreendev

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steue @jzempel @m-lai @zendesk-garden