feat: add new alt-text icons #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Nice @ginnywood. Can you verify for future reviewers that this passes i18n inspection?
Also, is this part of a larger set? Asking so I can plan the publish to NPM.
|
@jzempel this passes i18n inspection because the HTML attribute itself is only written in English. So it would be familiar in any language. These four icons are the only ones in the set. |
rossmoody
approved these changes
Aug 11, 2020
steue
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new icons:
12/alt-text-fill12/alt-text-stroke16/alt-text-fill16/alt-text-strokeDetail
See deployment link for review.
Checklist
designer as a reviewer)
yarn start)