Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new circle-line icons and resize existing circle icons to match #174

Merged
merged 1 commit into from
Jul 13, 2020
Merged

feat: add new circle-line icons and resize existing circle icons to match #174

merged 1 commit into from
Jul 13, 2020

Conversation

ginnywood
Copy link
Contributor

@ginnywood ginnywood commented Jul 10, 2020 •
edited
Loading

  • BREAKING CHANGE?

Description

New circle-line icons:

  • 12/circle-line-fill
  • 12/circle-line-stroke
  • 16/circle-line-fill
  • 16/circle-line-stroke

New circle-full-fill icons as counterparts to existing circle-full-stroke icons:

  • 12/circle-full-fill
  • 16/circle-full-fill

Resized circle-full-stroke icons to match new icons:

  • 12/circle-full-stroke

Detail

See deployment link for review.

Checklist

  • 👌 SVG updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 SVG demo is up-to-date (yarn start)
  • ◾ Renders as expected in "dark" mode
  • ⬜ Renders as expected @ 2x scale

@ginnywood ginnywood requested a review from a team as a code owner July 10, 2020 19:16
@zendesk-garden zendesk-garden temporarily deployed to staging July 10, 2020 19:18 Inactive
@ginnywood ginnywood changed the title Add new icons and resize existing circles to match feat: add new circle-line icons and resize existing circle icons to match Jul 10, 2020
rossmoody
rossmoody approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@rossmoody rossmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jzempel jzempel merged commit 1c7685a into main Jul 13, 2020
@jzempel jzempel deleted the gwood/add-article-status-icons branch July 13, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@m-lai m-lai m-lai approved these changes

@rossmoody rossmoody rossmoody approved these changes

@allisonacs allisonacs Awaiting requested review from allisonacs

@steue steue Awaiting requested review from steue

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ginnywood @jzempel @m-lai @rossmoody @zendesk-garden