Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add shapes icons #123

Merged
merged 1 commit into from
Oct 4, 2019
Merged

feat: add shapes icons #123

merged 1 commit into from
Oct 4, 2019

Conversation

rossmoody
Copy link
Contributor

  • BREAKING CHANGE?

Description

Adds the shapes icon in:

  • 12px-fill
  • 12px-stroke
  • 16px-fill
  • 16px-stroke
  • 26px

image

Checklist

  • 👌 SVG updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 SVG demo is up-to-date (yarn start)
  • ◾ Renders as expected in "dark" mode
  • ⬜ Renders as expected @ 2x scale

@rossmoody rossmoody requested review from jzempel and hzhu October 4, 2019 01:27
@rossmoody rossmoody requested a review from a team as a code owner October 4, 2019 01:27
@jzempel jzempel changed the title Add shapes icon feat: add shapes icons Oct 4, 2019
jzempel
jzempel approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic. Thanks @rossmoody.

@jzempel jzempel merged commit be1ddf3 into master Oct 4, 2019
@jzempel jzempel deleted the shapes-icon branch October 4, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@austingreendev austingreendev austingreendev approved these changes

@hzhu hzhu Awaiting requested review from hzhu

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rossmoody @jzempel @austingreendev