Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 26px platform icon #121

Merged
merged 2 commits into from
Oct 2, 2019
Merged

feat: add 26px platform icon #121

merged 2 commits into from
Oct 2, 2019

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Oct 1, 2019

  • BREAKING CHANGE?

Description

Adds a new 26px platform icon.

Detail

Demo page pre-published for review: https://garden.zendesk.com/svg-icons/26px/

Checklist

  • 👌 SVG updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 SVG demo is up-to-date (yarn start)
  • ◾ Renders as expected in "dark" mode
  • ⬜ Renders as expected @ 2x scale

@jzempel jzempel requested a review from ginnywood October 1, 2019 20:28
@jzempel jzempel requested a review from a team as a code owner October 1, 2019 20:28
hzhu
hzhu approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@hzhu hzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, LGTM.

@jzempel jzempel merged commit 2007763 into master Oct 2, 2019
@jzempel jzempel deleted the jzempel/add-platform branch October 2, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzhu hzhu hzhu approved these changes

@ginnywood ginnywood ginnywood approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzempel @hzhu @ginnywood