Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always error asynchronously from parseAsync method #412

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Always error asynchronously from parseAsync method #412

merged 1 commit into from
Sep 9, 2019

Conversation

juanjoDiaz
Copy link
Collaborator

Closes #411

@coveralls
Copy link

coveralls commented Aug 16, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 59b7973 on juanjoDiaz:always_error_async-from_parseAsync into e0baab8 on zemirco:master.

@juanjoDiaz
Copy link
Collaborator Author

Once you merge #413 I'll rebase and we can merge this.

@juanjoDiaz
Copy link
Collaborator Author

@knownasilya this is ready to go

Not to release. Since we can't release until 5.0 now.

@knownasilya
Copy link
Collaborator

Might be worthwhile to cherry pick into a 4x hotfix branch.

@juanjoDiaz juanjoDiaz mentioned this pull request Sep 3, 2019
Merged
@knownasilya knownasilya merged commit 16cc044 into zemirco:master Sep 9, 2019
@juanjoDiaz juanjoDiaz deleted the always_error_async-from_parseAsync branch November 9, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parseAsync method Error handling
3 participants
@juanjoDiaz @coveralls @knownasilya