-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements #360
Merged
knownasilya
merged 13 commits into
zemirco:master
from
juanjoDiaz:performance_improvements
Mar 10, 2019
Merged
Performance improvements #360
knownasilya
merged 13 commits into
zemirco:master
from
juanjoDiaz:performance_improvements
Mar 10, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, I just pushed here the new API as well. It's basically a convenient way to use the stream API. |
@knownasilya anything blocking for merging and releasing this? |
Ah, sorry missed the change that fixed the test. We could probably start using the reviewer feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bunch of performance improvement and an important bugfix that made reusing the same parser to become increasingly slower.
Should help with #359 .
I'll submit tomorrow or so another PR with a new Async API to be able to use streams in the browser at easy.