When unwinding 10 different nested values in a JSON object, 10 instances of the final nested value is returned #356

davekaj · 2019-02-21T03:59:05Z

Version - 4.3.4
node - 11.9.0

I ran the following code:

const Json2csvParser = require('json2csv').Parser
const fields = ['data.repository.pullRequests.nodes.author.login', 'data.repository.pullRequests.nodes.createdAt', 'data.repository.pullRequests.nodes.merged']
const json2csvParser = new Json2csvParser({ fields, unwind: ['data.repository.pullRequests.nodes.login', 'data.repository.pullRequests.nodes'] })
let parsed = json2csvParser.parse(test)
console.log(parsed)

Where test is:

let test =
{
   "data": {
      "repository": {
         "pullRequests": {
            "totalCount": 10728,
            "nodes": [
               {
                  "author": {
                     "login": "MarcoFalke"
                  },
                  "createdAt": "2019-02-18T20:03:05Z",
                  "merged": false
               },
               {
                  "author": {
                     "login": "AkioNak"
                  },
                  "createdAt": "2019-02-19T08:49:41Z",
                  "merged": true
               },
               {
                  "author": {
                     "login": "Sjors"
                  },
                  "createdAt": "2019-02-19T13:27:19Z",
                  "merged": false
               },
               {
                  "author": {
                     "login": "promag"
                  },
                  "createdAt": "2019-02-19T15:21:45Z",
                  "merged": false
               },
               {
                  "author": {
                     "login": "Sjors"
                  },
                  "createdAt": "2019-02-19T16:17:48Z",
                  "merged": false
               },
               {
                  "author": {
                     "login": "hebasto"
                  },
                  "createdAt": "2019-02-19T20:37:25Z",
                  "merged": false
               },
               {
                  "author": {
                     "login": "dongcarl"
                  },
                  "createdAt": "2019-02-19T21:02:10Z",
                  "merged": false
               },
               {
                  "author": {
                     "login": "ryanofsky"
                  },
                  "createdAt": "2019-02-20T15:17:23Z",
                  "merged": false
               },
               {
                  "author": {
                     "login": "achow101"
                  },
                  "createdAt": "2019-02-20T17:45:01Z",
                  "merged": false
               },
               {
                  "author": {
                     "login": "HashUnlimited"
                  },
                  "createdAt": "2019-02-20T20:01:03Z",
                  "merged": false
               }
            ]
         }
      }
   }
}

The returned value is this:

"data.repository.pullRequests.nodes.author.login","data.repository.pullRequests.nodes.createdAt","data.repository.pullRequests.nodes.merged"
"HashUnlimited","2019-02-20T20:01:03Z",false
"HashUnlimited","2019-02-20T20:01:03Z",false
"HashUnlimited","2019-02-20T20:01:03Z",false
"HashUnlimited","2019-02-20T20:01:03Z",false
"HashUnlimited","2019-02-20T20:01:03Z",false
"HashUnlimited","2019-02-20T20:01:03Z",false
"HashUnlimited","2019-02-20T20:01:03Z",false
"HashUnlimited","2019-02-20T20:01:03Z",false
"HashUnlimited","2019-02-20T20:01:03Z",false
"HashUnlimited","2019-02-20T20:01:03Z",false

As you can see, I am getting the last value HashUnlimited 10 times, instead of the 10 different values.

Am I using this function incorrectly? Or is this a bug?

Thanks for your time!

The text was updated successfully, but these errors were encountered:

juanjoDiaz · 2019-02-21T07:34:34Z

Hi @davekaj,

Can you also add the CSV that you would expect so I know what you are trying to do?
It could be a bug indeed...

danidesignassured · 2019-02-21T11:20:56Z

Hi there I have same issue with unwind,
I am trying to unwind groundwork column, it is an array which contains: 4 items
The unwind is creating 4 rows as expected but the field groundwork is getting always the latest item only....
I have uploaded the csv file generated ....
The expected result would be:

const opts = { fields, unwind: ['data.data.groundwork']} const parser = new json2csv.Parser(opts) const csv = parser.parse(self.forms_aux)

here is my json obj

TPR_Forms.csv.zip

davekaj · 2019-02-21T13:08:55Z

Hey @juanjoDiaz , I have posted below the desired output:

"login","createdAt","merged"
"MarcoFalke","2019-02-18T20:03:05Z","False"
"AkioNak","2019-02-19T08:49:41Z","True"
"Sjors","2019-02-19T13:27:19Z","False"
"promag","2019-02-19T15:21:45Z","False"
"Sjors","2019-02-19T16:17:48Z","False"
"hebasto","2019-02-19T20:37:25Z","False"
"dongcarl","2019-02-19T21:02:10Z","False"
"ryanofsky","2019-02-20T15:17:23Z","False"
"achow101","2019-02-20T17:45:01Z","False"
"HashUnlimited","2019-02-20T20:01:03Z","False"

warerebel · 2019-02-21T17:04:28Z

I have the same issue when unwinding where I only receive copies of the last element in an array. Interestingly if I run with unwind-blank I get the desired result of one line per array item.
This bug also only appears for me if the array is more than one nested depth.
Reproducible examples for each scenario provided below:

Example - unwind not working with nested array
JSON
{
"data":{
"metaData": "object name",
"item": {
"items": [
"index0", "index1"
]
}
}
}

Command
json2csv -i myJSON -H -f data.metaData,data.item.items -u data.item.items

Output
"object name","index1"
"object name","index1"

Example - unwind blank working with nested array

Command
json2csv -i myJSON -H -f data.metaData,data.item.items -u data.item.items -B

Output
"object name","index0"
,"index1"

Example - unwind working ok with array not nested more than 1 depth

JSON
{
"data":{
"metaData": "object name",
"items": [
"index0", "index1"
]
}
}

Command
json2csv -i myJSON -H -f data.metaData,data.items -u data.items

Output
"object name","index0"
"object name","index1"

knownasilya · 2019-02-22T02:18:37Z

Released in v4.3.5, thanks @juanjoDiaz

juanjoDiaz · 2019-02-22T06:33:41Z

Can you guys confirm that it looks ok?

warerebel · 2019-02-22T08:48:12Z

I confirm it has resolved my issue and all my tests pass.

And thank you!!!

danidesignassured · 2019-02-22T10:33:59Z

It is working for me now as well.
Thank you for the prompt fix!! 🥇

juanjoDiaz added the question label Feb 21, 2019

juanjoDiaz added bug and removed question labels Feb 21, 2019

juanjoDiaz mentioned this issue Feb 21, 2019

Fix unwind of nested fields #357

Merged

knownasilya closed this as completed in #357 Feb 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When unwinding 10 different nested values in a JSON object, 10 instances of the final nested value is returned #356

When unwinding 10 different nested values in a JSON object, 10 instances of the final nested value is returned #356

davekaj commented Feb 21, 2019

juanjoDiaz commented Feb 21, 2019

danidesignassured commented Feb 21, 2019 •

edited

Loading

davekaj commented Feb 21, 2019

warerebel commented Feb 21, 2019

knownasilya commented Feb 22, 2019

juanjoDiaz commented Feb 22, 2019

warerebel commented Feb 22, 2019 •

edited

Loading

danidesignassured commented Feb 22, 2019

When unwinding 10 different nested values in a JSON object, 10 instances of the final nested value is returned #356

When unwinding 10 different nested values in a JSON object, 10 instances of the final nested value is returned #356

Comments

davekaj commented Feb 21, 2019

juanjoDiaz commented Feb 21, 2019

danidesignassured commented Feb 21, 2019 • edited Loading

davekaj commented Feb 21, 2019

warerebel commented Feb 21, 2019

knownasilya commented Feb 22, 2019

juanjoDiaz commented Feb 22, 2019

warerebel commented Feb 22, 2019 • edited Loading

danidesignassured commented Feb 22, 2019

danidesignassured commented Feb 21, 2019 •

edited

Loading

warerebel commented Feb 22, 2019 •

edited

Loading