Update dependencies and remove cli-table2 dependency #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, remove node 4 from the tests as suggested by #303 since it's not supported by the latest eslint. json2csv should still work on node 4, especially the rollup version. It's just not officially tested. |
|
@knownasilya is there anything blocking this at the moment? Are you happy to get the change merged? |
knownasilya
reviewed
Jul 6, 2018
bin/utils/TablePrinter.js
Outdated
| } | ||
|
|
||
| printCSV(csv) { | ||
| printCSV(csv) { // SYNC |
There was a problem hiding this comment.
Should this comment be expanded?
There was a problem hiding this comment.
Yeah!
I just removed it. It was a pretty unnecessary comment imo 🙂
|
Restarting a timedout test for node 6, then I'll merge it once green. |
|
Gentle reminder 🙂 |
This was referenced Jul 12, 2018
|
v4.1.6 released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped all dependencies to the latest versions.
Fix a new eslint rule (self-assigning)
Remove dependency to cli-table2 to solve vulnerability.
This closes #297 and supersedes #302 and #311.
I still think that we should get rid of this complete and move to an external library. But, until I have time to do so, I think that this solution is good enough. No extra flags or external libraries needed. And colors removed completely to fix tests.