Rename unwindPath to unwind #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can also probably rename |
…e_unwindPath_to_unwind # Conflicts: # README.md
|
Yup. Just added it and fixed the conflict. (I used merge instead of rebase because you are squashing the commits anyway.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are breaking the API for the next version. Let's try to make it as good as possible.
This PR rename
unwindPathto justunwindwhich is nicer and cleaner.I'd suggest that you guys take a look at the current options to see if there is anything that could be improve. I'm happy to do the changes if you just let me know.