Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues is that
line.replace(/\\\\/g,'\\')
is performed twice during the CSV. And the test are tweaked to pass with this weird logic.In the the
should parse JSON values with trailing backslashes
test for example:The JSON file contains
"Audi\\\\"
. However,"Audi\"
is expected in the resulting CSV.I would expect the correct escaped value to be
"Audi\\"
Or the
should not escape quotes with double quotes, when there is a backslash in the end
test receives as inputHowever, it expects and output like:
It seems completely wrong that 2 strings that are different in the JSON are yielding exactly the same values in the CSV.
I would expect the final row to be
"with a description and ""quotes and backslash\\"