fix: error when a field is null and flatten is used (#274)

zemirco · Apr 2, 2018 · 1349a94 · 1349a94
1 parent e3ebed6
commit 1349a94
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/bin/utils/TablePrinter.js b/bin/utils/TablePrinter.js
@@ -15,11 +15,12 @@ class TablePrinter {
     const lines = csv.split(this.opts.eol);
 
     const chars = {
-        'bottom': '',
-        'bottom-mid': '',
-        'bottom-left': '',
-        'bottom-right': ''
-      };
+      'bottom': '',
+      'bottom-mid': '',
+      'bottom-left': '',
+      'bottom-right': ''
+    };
+
     if (!this._hasWritten) {
       this.colWidths = this.getColumnWidths(lines[0]);
       if (this.opts.header) {

diff --git a/lib/JSON2CSVBase.js b/lib/JSON2CSVBase.js
@@ -208,6 +208,7 @@ class JSON2CSVBase {
           : key;
 
         if (typeof value !== 'object'
+          || value === null
           || Array.isArray(value)
           || Object.prototype.toString.call(value.toJSON) === '[object Function]'
           || !Object.keys(value).length) {

diff --git a/test/fixtures/csv/flattenToJSON.csv b/test/fixtures/csv/flattenToJSON.csv
@@ -1,2 +1,2 @@
-"hello.world","lorem.ipsum.dolor"
-"good afternoon","good evening"
+"hello.world","lorem.ipsum.dolor","lorem.ipsum.value"
+"good afternoon","good evening",
diff --git a/test/fixtures/json/flattenToJSON.js b/test/fixtures/json/flattenToJSON.js
@@ -7,7 +7,8 @@ module.exports = {
   },
   lorem: {
     ipsum: {
-      dolor: 'good evening'
+      dolor: 'good evening',
+      value: null
     }
   }
 }