Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Split into davincibox and davincibox-opencl #121

Merged
merged 19 commits into from
Sep 16, 2024

Conversation

zelikos
Copy link
Owner

@zelikos zelikos commented Sep 14, 2024

Based on findings in #114 (comment) it seems that having the akmod-nvidia and CUDA packages installed into the container actually cause problems, and through nvidia-container-toolkit the container actually uses the host NVIDIA drivers just fine.

This PR splits davincibox into two builds: davincibox that contains only DaVinci Resolve dependencies and no drivers, for use on NVIDIA GPUs with nvidia-container-toolkit, and davincibox-opencl for AMD & Intel with their respective compute packages (intel-compute-runtime and rocm-opencl).

In theory, this will likely resolve #96 #114 and #117 and may help with #40

@zelikos zelikos changed the title fix: Remove nvidia driver packages fix: Remove nvidia driver packages, install OpenCL during setup Sep 14, 2024
@zelikos zelikos changed the title fix: Remove nvidia driver packages, install OpenCL during setup refactor!: Split into davincibox and davincibox-opencl Sep 14, 2024
@zelikos zelikos marked this pull request as ready for review September 14, 2024 20:47
@zelikos
Copy link
Owner Author

zelikos commented Sep 14, 2024

The new builds from this PR can be tested by following the manual setup instructions as normal, but replacing the latest tag with pr-121:

NVIDIA:

distrobox create -i ghcr.io/zelikos/davincibox:pr-121 -n davincibox --nvidia

AMD & Intel:

distrobox create -i ghcr.io/zelikos/davincibox-opencl:pr-121 -n davincibox

The AMD side with davincibox-opencl is working as expected on my end.

cc @DaoistNeko and @Zeglius if either of you could test the NVIDIA image

@Zeglius
Copy link
Contributor

Zeglius commented Sep 15, 2024

Seems is not working. Nothing happens by using the app shortcut. Manually launching from distrobox I get this
image

@zelikos zelikos marked this pull request as draft September 15, 2024 16:08
@zelikos
Copy link
Owner Author

zelikos commented Sep 15, 2024

Re-added mesa-libOpenCL to the main dependencies, since I notice now that it wasn't on the list removed in #114 (comment). I wonder if we could keep intel-compute-runtime in too, and maybe we only had to omit ROCm from the main container for NVIDIA to work...?

@Zeglius
Copy link
Contributor

Zeglius commented Sep 16, 2024

Re-added mesa-libOpenCL to the main dependencies, since I notice now that it wasn't on the list removed in #114 (comment). I wonder if we could keep intel-compute-runtime in too, and maybe we only had to omit ROCm from the main container for NVIDIA to work...?

Installed mesa-libOpenCL in the container, seems that makes it work.

By adding intel-compute-runtime however, I get the "cant start GPU" error.
image

@zelikos
Copy link
Owner Author

zelikos commented Sep 16, 2024

Re-added mesa-libOpenCL to the main dependencies, since I notice now that it wasn't on the list removed in #114 (comment). I wonder if we could keep intel-compute-runtime in too, and maybe we only had to omit ROCm from the main container for NVIDIA to work...?

Installed mesa-libOpenCL in the container, seems that makes it work.

By adding intel-compute-runtime however, I get the "cant start GPU" error. image

To clarify, with just mesa-libOpenCL added, Resolve starts as normal, and it detects CUDA just fine too?

@zelikos zelikos marked this pull request as ready for review September 16, 2024 17:25
@Beryesa
Copy link

Beryesa commented Sep 16, 2024

I have an amd apu with dedicated Nvidia graphics (laptop) may I help with testing or

  • would testing on amd igpu help/work at all
  • Do you know either PRIME/offload is not fundamentally broken?
    Thanks :3

@zelikos
Copy link
Owner Author

zelikos commented Sep 16, 2024

I have an amd apu with dedicated Nvidia graphics (laptop) may I help with testing or

* would testing on amd igpu help/work at all

* Do you know either PRIME/offload is not fundamentally broken?
  Thanks :3

Multi-GPU laptop setups like yours are a known issue that may or may not work; you're welcome to try testing this PR anyway, and the changes here might also actually help, but ultimately that type of setup would be a separate issue than what this PR is intended solve.

@Zeglius
Copy link
Contributor

Zeglius commented Sep 16, 2024

Re-added mesa-libOpenCL to the main dependencies, since I notice now that it wasn't on the list removed in #114 (comment). I wonder if we could keep intel-compute-runtime in too, and maybe we only had to omit ROCm from the main container for NVIDIA to work...?

Installed mesa-libOpenCL in the container, seems that makes it work.
By adding intel-compute-runtime however, I get the "cant start GPU" error. image

To clarify, with just mesa-libOpenCL added, Resolve starts as normal, and it detects CUDA just fine too?

mesa-libOpenCL + all the other dependencies from the PR's container image (ghcr.io/zelikos/davincibox:pr-121) yep.

@zelikos
Copy link
Owner Author

zelikos commented Sep 16, 2024

Re-added mesa-libOpenCL to the main dependencies, since I notice now that it wasn't on the list removed in #114 (comment). I wonder if we could keep intel-compute-runtime in too, and maybe we only had to omit ROCm from the main container for NVIDIA to work...?

Installed mesa-libOpenCL in the container, seems that makes it work.
By adding intel-compute-runtime however, I get the "cant start GPU" error. image

To clarify, with just mesa-libOpenCL added, Resolve starts as normal, and it detects CUDA just fine too?

mesa-libOpenCL + all the other dependencies from the PR's container image (ghcr.io/zelikos/davincibox:pr-121) yep.

Right, that's what I meant, sorry for being unclear. Thanks for confirming

@zelikos
Copy link
Owner Author

zelikos commented Sep 16, 2024

Gonna go ahead and merge since I've confirmed the AMD side works, and it sounds like NVIDIA on Bazzite works too.

@svyatoclav

This comment was marked as off-topic.

@zelikos

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Nvidia GPU integration on Linux Mint
4 participants