Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository URL to package.json #10748

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Add repository URL to package.json #10748

merged 2 commits into from
Apr 6, 2020

Conversation

ykzts
Copy link
Contributor

@ykzts ykzts commented Feb 29, 2020

Services like Renovate combine monorepo into one based on the URL of the repository written in package.json.

@ijjk
Copy link
Member

ijjk commented Feb 29, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ykzts/next.js repo Change
buildDuration 10.2s 10.3s ⚠️ +44ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +101 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ykzts/next.js repo Change
main-HASH.js gzip 5.41 kB 5.41 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55 kB 55 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ykzts/next.js repo Change
main-HASH.module.js gzip 4.44 kB 4.44 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51 kB 51 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ykzts/next.js repo Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ykzts/next.js repo Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary ykzts/next.js repo Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ykzts/next.js repo Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary ykzts/next.js repo Change
index.html gzip 924 B 924 B
link.html gzip 932 B 932 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ykzts/next.js repo Change
buildDuration 11.2s 11.3s ⚠️ +46ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +101 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ykzts/next.js repo Change
main-HASH.js gzip 5.41 kB 5.41 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55 kB 55 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ykzts/next.js repo Change
main-HASH.module.js gzip 4.44 kB 4.44 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51 kB 51 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ykzts/next.js repo Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ykzts/next.js repo Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary ykzts/next.js repo Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ykzts/next.js repo Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary ykzts/next.js repo Change
_error.js gzip 292 kB 292 kB -745 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 293 kB 293 kB -211 B
link.js gzip 299 kB 299 kB -271 B
routerDirect.js gzip 298 kB 299 kB ⚠️ +1.1 kB
withRouter.js gzip 298 kB 299 kB ⚠️ +736 B
Overall change 1.48 MB 1.48 MB ⚠️ +612 B

Commit: 02ed08e

@timneutkens
Copy link
Member

@ykzts how does this relate to your use case exactly? All of these shouldn't be used directly, plugins are experimental and will likely change.

@ykzts
Copy link
Contributor Author

ykzts commented Feb 29, 2020

Yes, I understand that these packages are experimental. I made a pull request because it would be inconvenient if you didn't specify a repository when you were actually production ready. We do not expect this value to change significantly.

# Conflicts:
#	packages/next-plugin-google-analytics/package.json
#	packages/next-plugin-material-ui/package.json
#	packages/next-plugin-sentry/package.json
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants