Remove Now CLI reference from examples #10501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
Commit: b384969 |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| buildDuration | 9.6s | 9.8s | |
| nodeModulesSize | 52.9 MB | 52.9 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.13 kB | 5.13 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..e781.js gzip | 13.8 kB | 13.8 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 67.5 kB | 67.5 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.13 kB | 4.13 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _error.js gzip | 289 kB | 290 kB | |
| 404.html gzip | 1.45 kB | 1.45 kB | ✓ |
| hooks.html gzip | 1.08 kB | 1.08 kB | ✓ |
| index.js gzip | 289 kB | 289 kB | -186 B |
| link.js gzip | 319 kB | 319 kB | -285 B |
| routerDirect.js gzip | 316 kB | 317 kB | |
| withRouter.js gzip | 316 kB | 317 kB | |
| Overall change | 1.53 MB | 1.53 MB |
Commit: 261dccf
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
Commit: 261dccf |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| buildDuration | 12.8s | 13.2s | |
| nodeModulesSize | 52.9 MB | 52.9 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.13 kB | 5.13 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..e781.js gzip | 13.8 kB | 13.8 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 67.5 kB | 67.5 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.13 kB | 4.13 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _error.js gzip | 289 kB | 290 kB | |
| 404.html gzip | 1.45 kB | 1.45 kB | ✓ |
| hooks.html gzip | 1.08 kB | 1.08 kB | ✓ |
| index.js gzip | 290 kB | 289 kB | -872 B |
| link.js gzip | 319 kB | 320 kB | |
| routerDirect.js gzip | 317 kB | 316 kB | -752 B |
| withRouter.js gzip | 317 kB | 317 kB | |
| Overall change | 1.53 MB | 1.53 MB |
Commit: 5355f88
chibicode
commented
Feb 12, 2020
| @@ -16,7 +16,7 @@ This is a full-stack TypeScript example using: | |||
| ### Included functionality | |||
|
|
|||
| - Making `.env` variables available to next: [next.config.js](next.config.js) | |||
| - **_NOTE_**: when deploying with Now you need to [add your secrets](https://zeit.co/docs/v2/serverless-functions/env-and-secrets) and specify a [now.json](/now.json) file. | |||
| - **Note**: When deploying with Now you need to [add your secrets](https://zeit.co/docs/v2/serverless-functions/env-and-secrets) and specify a [now.json](/now.json) file. | |||
There was a problem hiding this comment.
Just a formatting change here
chibicode
commented
Feb 12, 2020
Comment on lines
97
to
101
| ### Deploy | ||
|
|
||
| Install [Now](https://zeit.co/now) ([download](https://zeit.co/download)) | ||
| Deploy it to the cloud with [ZEIT Now](https://zeit.co/new?filter=next.js&utm_source=github&utm_medium=readme&utm_campaign=next-example) ([Documentation](https://nextjs.org/docs/deployment)). | ||
|
|
||
| Add your Stripe [secrets to Now](https://zeit.co/docs/v2/serverless-functions/env-and-secrets): | ||
| **Note**: You must add your Stripe secrets using Now CLI ([Download here](https://zeit.co/download)): |
There was a problem hiding this comment.
This is the same as others
chibicode
commented
Feb 12, 2020
|
|
||
| ```bash | ||
| now secrets rm stripe_webhook_secret | ||
| now secrets add stripe_webhook_secret whsec_*** | ||
| ``` | ||
|
|
||
| As the secrets are set as env vars in the project at deploy time, we will need to redeploy our app after we made changes to the secrets. Run `now` again to redeploy with the new secret value. | ||
| As the secrets are set as env vars in the project at deploy time, we will need to redeploy our app after we made changes to the secrets. |
There was a problem hiding this comment.
Removed "run now again"
chibicode
commented
Feb 12, 2020
|
|
||
| ```bash | ||
| now secrets add stripe_publishable_key pk_*** | ||
| now secrets add stripe_secret_key sk_*** | ||
| now secrets add stripe_webhook_secret whsec_*** | ||
| ``` | ||
|
|
||
| To start the deploy, run: | ||
| After deploying, copy the deployment URL with the webhook path (`https://your-url.now.sh/api/webhooks`) and create a live webhook endpoint [in your Stripe dashboard](https://stripe.com/docs/webhooks/setup#configure-webhook-settings). |
There was a problem hiding this comment.
Removed "Now will show you the URL"
lfades
reviewed
Feb 12, 2020
Co-Authored-By: Luis Alvarez D. <[email protected]>
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| buildDuration | 13.3s | 13.3s | |
| nodeModulesSize | 52.9 MB | 52.9 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.13 kB | 5.13 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..e781.js gzip | 13.8 kB | 13.8 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 67.5 kB | 67.5 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.13 kB | 4.13 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _error.js gzip | 289 kB | 289 kB | |
| 404.html gzip | 1.45 kB | 1.45 kB | ✓ |
| hooks.html gzip | 1.08 kB | 1.08 kB | ✓ |
| index.js gzip | 290 kB | 289 kB | -647 B |
| link.js gzip | 320 kB | 319 kB | -428 B |
| routerDirect.js gzip | 317 kB | 317 kB | |
| withRouter.js gzip | 316 kB | 317 kB | |
| Overall change | 1.53 MB | 1.53 MB |
Commit: f7582e6
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| buildDuration | 11.7s | 12.1s | |
| nodeModulesSize | 52.9 MB | 52.9 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.13 kB | 5.13 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..e781.js gzip | 13.8 kB | 13.8 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 67.5 kB | 67.5 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.13 kB | 4.13 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | chibicode/next.js remove-cli-from-examples | Change | |
|---|---|---|---|
| _error.js gzip | 290 kB | 289 kB | -760 B |
| 404.html gzip | 1.45 kB | 1.45 kB | ✓ |
| hooks.html gzip | 1.08 kB | 1.08 kB | ✓ |
| index.js gzip | 289 kB | 289 kB | |
| link.js gzip | 320 kB | 320 kB | -219 B |
| routerDirect.js gzip | 316 kB | 317 kB | |
| withRouter.js gzip | 316 kB | 316 kB | |
| Overall change | 1.53 MB | 1.53 MB |
Commit: 0b70c54
This was referenced Mar 13, 2020
This was referenced Mar 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Now CLI reference from examples.
Converts this:
...into this:
Notes
contributing.mdis also updated: f122cc5filter=next.jsand has the following tracking code:utm_source=githubutm_medium=readmeutm_campaign=next-example