get the http2 example to work #10470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: eef5ece |
Timer
requested changes
Feb 8, 2020
examples/with-http2/server.js
Outdated
| dev, | ||
| conf: { | ||
| // this needs to be set false unitl to a bug in the compression npm module ets fixed. | ||
| compress: false, |
There was a problem hiding this comment.
This should be set in next.config.js, not here!
There was a problem hiding this comment.
yes of course!! moved it to next.config.js
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: abfec0e |
Janpot
reviewed
Feb 9, 2020
examples/with-http2/next.config.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| module.exports = { | |||
| // this needs to be set false unitl to a bug in the compression npm module gets fixed. | |||
There was a problem hiding this comment.
Suggested change
| // this needs to be set false unitl to a bug in the compression npm module gets fixed. | |
| // this needs to be set false until a bug in the compression npm module gets fixed. |
Might want to add a link in this comment to the corresponding issue on GitHub
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: a56e9f9 |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: d8bff8d |
Janpot
reviewed
Feb 9, 2020
Co-Authored-By: Jan Potoms <[email protected]>
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 110cc1d |
timneutkens
approved these changes
Feb 9, 2020
Timer
approved these changes
Feb 10, 2020
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 9e35bc3 |
chibicode
pushed a commit
to chibicode/next.js
that referenced
this pull request
Feb 11, 2020
* copy only the necessary files during stage 2 in multi-stage. * update readme * adds compress:false to prevent the server from crashing while running http2 * moving the config to next.config * link to the issue * fix grammatical error * Update examples/with-http2/next.config.js Co-Authored-By: Jan Potoms <[email protected]> Co-authored-by: Jan Potoms <[email protected]> Co-authored-by: Joe Haddad <[email protected]>
This was referenced Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on one of the issues raised around trying to get the with-http2 example working, I've added the compress:false config with a comment regarding the bug related to the compression module