Modify splitChunksPlugin to give shared CSS chunks different names #10408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atcastle
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
Stats from current PRDefault Server ModeGeneral Overall increase
|
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| buildDuration | 12.2s | 12.3s | |
| nodeModulesSize | 52.1 MB | 52.1 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.12 kB | 5.12 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.12 kB | 4.12 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| index.html gzip | 1.02 kB | 1.02 kB | ✓ |
| link.html gzip | 1.03 kB | 1.03 kB | ✓ |
| withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
| Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| buildDuration | 12.8s | 12.7s | -96ms |
| nodeModulesSize | 52.1 MB | 52.1 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.12 kB | 5.12 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.12 kB | 4.12 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _error.js gzip | 46.5 kB | 46.5 kB | ✓ |
| 404.html gzip | 1.43 kB | 1.43 kB | ✓ |
| hooks.html gzip | 1.07 kB | 1.07 kB | ✓ |
| index.js gzip | 46.5 kB | 46.5 kB | ✓ |
| link.js gzip | 72 kB | 72 kB | ✓ |
| routerDirect.js gzip | 70.3 kB | 70.3 kB | ✓ |
| withRouter.js gzip | 70.1 kB | 70.1 kB | ✓ |
| Overall change | 308 kB | 308 kB | ✓ |
Commit: befc190
Timer
approved these changes
Feb 4, 2020
Stats from current PRDefault Server ModeGeneral Overall increase
|
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| buildDuration | 11.9s | 11.6s | -280ms |
| nodeModulesSize | 52.2 MB | 52.2 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.12 kB | 5.12 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.12 kB | 4.12 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| index.html gzip | 1.02 kB | 1.02 kB | ✓ |
| link.html gzip | 1.03 kB | 1.03 kB | ✓ |
| withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
| Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| buildDuration | 12s | 12.2s | |
| nodeModulesSize | 52.2 MB | 52.2 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.12 kB | 5.12 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.12 kB | 4.12 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _error.js gzip | 46.5 kB | 46.5 kB | ✓ |
| 404.html gzip | 1.43 kB | 1.43 kB | ✓ |
| hooks.html gzip | 1.07 kB | 1.07 kB | ✓ |
| index.js gzip | 46.5 kB | 46.5 kB | ✓ |
| link.js gzip | 72 kB | 72 kB | ✓ |
| routerDirect.js gzip | 70.3 kB | 70.3 kB | ✓ |
| withRouter.js gzip | 70.1 kB | 70.1 kB | ✓ |
| Overall change | 308 kB | 308 kB | ✓ |
Commit: 888a1d7
Stats from current PRDefault Server ModeGeneral Overall increase
|
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| buildDuration | 12.6s | 13s | |
| nodeModulesSize | 52.2 MB | 52.2 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.12 kB | 5.12 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.12 kB | 4.12 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| index.html gzip | 1.02 kB | 1.02 kB | ✓ |
| link.html gzip | 1.03 kB | 1.03 kB | ✓ |
| withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
| Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| buildDuration | 13.2s | 13.1s | -79ms |
| nodeModulesSize | 52.2 MB | 52.2 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.12 kB | 5.12 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.12 kB | 4.12 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _error.js gzip | 46.5 kB | 46.5 kB | ✓ |
| 404.html gzip | 1.43 kB | 1.43 kB | ✓ |
| hooks.html gzip | 1.07 kB | 1.07 kB | ✓ |
| index.js gzip | 46.5 kB | 46.5 kB | ✓ |
| link.js gzip | 72 kB | 72 kB | ✓ |
| routerDirect.js gzip | 70.3 kB | 70.3 kB | ✓ |
| withRouter.js gzip | 70.1 kB | 70.1 kB | ✓ |
| Overall change | 308 kB | 308 kB | ✓ |
Commit: 33bd99c
Stats from current PRDefault Server ModeGeneral Overall increase
|
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| buildDuration | 12.9s | 13s | |
| nodeModulesSize | 52.5 MB | 52.5 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.12 kB | 5.12 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.12 kB | 4.12 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| index.html gzip | 1.02 kB | 1.02 kB | ✓ |
| link.html gzip | 1.03 kB | 1.03 kB | ✓ |
| withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
| Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| buildDuration | 13.5s | 13.5s | |
| nodeModulesSize | 52.5 MB | 52.5 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.12 kB | 5.12 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
| commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
| de003c3a9d30..d6ae.js gzip | 16.2 kB | 16.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 69.9 kB | 69.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.12 kB | 4.12 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
| de003c3a9d30..dule.js gzip | 15.1 kB | 15.1 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 64.6 kB | 64.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
| Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.js gzip | 1.15 kB | 1.15 kB | ✓ |
| _error.js gzip | 4.07 kB | 4.07 kB | ✓ |
| hooks.js gzip | 779 B | 779 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.89 kB | 2.89 kB | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _app.module.js gzip | 576 B | 576 B | ✓ |
| _error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks.module.js gzip | 371 B | 371 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
| routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
| withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | atcastle/next.js split-chunks-css | Change | |
|---|---|---|---|
| _error.js gzip | 46.5 kB | 46.5 kB | ✓ |
| 404.html gzip | 1.43 kB | 1.43 kB | ✓ |
| hooks.html gzip | 1.07 kB | 1.07 kB | ✓ |
| index.js gzip | 46.5 kB | 46.5 kB | ✓ |
| link.js gzip | 72 kB | 72 kB | ✓ |
| routerDirect.js gzip | 70.3 kB | 70.3 kB | ✓ |
| withRouter.js gzip | 70.1 kB | 70.1 kB | ✓ |
| Overall change | 308 kB | 308 kB | ✓ |
Commit: 9cabfb2
chibicode
pushed a commit
to chibicode/next.js
that referenced
this pull request
Feb 11, 2020
…ercel#10408) * Modify splitChunksPlugin to give shared CSS chunks different names * fix lint Co-authored-by: Joe Haddad <[email protected]>
This was referenced Mar 13, 2020
This was referenced Mar 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is the fix for the performance regressions for some sites using granular chunks. The previous naming system for shared chunks is causing minSize to get ignored for CSS chunks, because they share the same name as (big enough) JS chunks. This is resulting in the creation of lots of tiny CSS chunks, slowing down initial CSS loading and FCP.
The fix simply modifies the splitChunksPlugin name test so it produces a different name for CSS chunks.
I've only tested this on one app so far--I'll try a few more tomorrow then ping about getting this merged.