Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up arrow key does not work in bash.exe #1127

Closed
mqudsi opened this issue Dec 12, 2016 · 25 comments
Closed

Up arrow key does not work in bash.exe #1127

mqudsi opened this issue Dec 12, 2016 · 25 comments

Comments

@mqudsi
Copy link
Contributor

mqudsi commented Dec 12, 2016

Running 1.0.0, starting hyper, then starting bash.exe with no other changes or configurations, the up arrow key does not work out of the box. This is on Windows 10 version 1607.

@khuongduybui
Copy link

Not only up but all arrow keys.
This issue is very common among console emulators on Windows.
See https://conemu.github.io/en/BashOnWindows.html#some-techinfo

@stefanivic
Copy link
Contributor

stefanivic commented Dec 12, 2016

@mqudsi this is an issue with Bash on Windows microsoft/WSL#111.

@nolanlawson
Copy link

For the time being I'm using history plus !-1 (to run the last command) or !106 (to run e.g. the 106th command), but looking forward to a fix from the BOW team!

@warpdesign
Copy link

Ctrl+x doesn't work eather (could not exit nano).

@stefanivic
Copy link
Contributor

@warpdesign you can use Ctrl+Shift+x to exit.

@stereokai
Copy link

@stefanivic, @Tyriar from the VSCode team is also watching this issue. Maybe both teams can combine efforts?

@Maximus5 of ConEmu was able to develop a solution by translating "native keypresses into Xterm compatible keypresses" is it something relevant to Hyper and worth looking into?

@Tyriar
Copy link
Contributor

Tyriar commented Dec 13, 2016

@stereokai I'm actually in the process of updating https://github.com/Tyriar/pty.js to use [email protected] which appears to have fixed this issue: https://github.com/rprichard/winpty/releases

Stay tuned: https://github.com/Tyriar/pty.js/issues/10

@stereokai
Copy link

That rocks. I hope it ends up working!

@jonathanrdelgado
Copy link

Updating pty.js may resolve #1174 and #1180 as well, please keep us informed.

@Tyriar
Copy link
Contributor

Tyriar commented Dec 13, 2016

Yes I'm hoping it will fix some other random Windows issues such as these microsoft/vscode#14613, it's hard to know until it's done though.

@jcolesio
Copy link

Just wanted to see if you had any luck resolving the arrow issues?

Would love to start using Hyper for my WSL setup.

@Tyriar
Copy link
Contributor

Tyriar commented Jan 20, 2017

@jcolesio should be fixed when node-pty is upgraded to 0.6.0.

matheuss added a commit that referenced this issue Jan 21, 2017
@schmic
Copy link

schmic commented Jan 22, 2017

Until then you can use mintty/wsltty

shell: 'C:\\Users\\%USERNAME%\\AppData\\Local\\wsltty\\bin\\wslbridge.exe',
shellArgs: ['-t', '-C~', '/bin/zsh'],

Replace %USERNAME% with ours as hyper doesn't resolve env variables (yet). Omit the last argument if you use bash instead of zsh.

@jcolesio
Copy link

jcolesio commented Jan 23, 2017 via email

@khuongduybui
Copy link

@jcolesio the shell: ..., shellArgs: ... arguments are set inside hyper settings file.

@jcolesio
Copy link

Thanks guys, worked perfectly!

@jcolesio
Copy link

Do you guys have any issues with WSL in hyper that when deleting things from the command line it retains some old characters depending how much I am deleting from the command line?

@CheshireSwift
Copy link

Yeah, I also have it echoing back my commands before the output of each.

@nolanlawson
Copy link

This seems fixed, using Windows Insider 15049 and Hyper 1.2.1. Also reported working on 15042: davatron5000/can-i-subsystem-it#4 (comment)

@matheuss
Copy link
Member

matheuss commented Mar 3, 2017

Indeed @nolanlawson, it's fixed – I forgot to close 😅 Thank you 🙌

@matheuss matheuss closed this as completed Mar 3, 2017
@matheuss
Copy link
Member

matheuss commented Mar 3, 2017

Btw, huge props to @Tyriar 🥇

@Tyriar
Copy link
Contributor

Tyriar commented Mar 3, 2017

🎉

@stereokai
Copy link

@nolanlawson @matheuss @Tyriar

That's weird. I've had it working since version 1,2,0, and I'm on Windows 10 14393.693 - I'm not an insider.

@Tyriar
Copy link
Contributor

Tyriar commented Mar 6, 2017

@stereokai it would have been fixed in a Hyper version, not Windows.

@stereokai
Copy link

@Tyriar I wrote that because 4 days ago @nolanlawson specified his Windows version (recent build from Windows Insider Program), so I thought he meant there was a fix implemented in the Windows build he's on.

This seems fixed, using Windows Insider 15049 and Hyper 1.2.1. Also reported working on 15042:
davatron5000/can-i-subsystem-it#4 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests