Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support customized max container depth #3

Merged
merged 1 commit into from
Feb 16, 2023
Merged

support customized max container depth #3

merged 1 commit into from
Feb 16, 2023

Conversation

zekun000
Copy link
Contributor

@zekun000 zekun000 commented Dec 6, 2022

No description provided.

@vgao1996
Copy link

vgao1996 commented Dec 6, 2022

Should probably bump crate version to 1.4.1

@zekun000
Copy link
Contributor Author

zekun000 commented Dec 6, 2022

version bump probably should be a separate change

@ma2bd ma2bd requested review from ma2bd and bmwill January 23, 2023 05:24
bmwill
bmwill reviewed Jan 23, 2023
View reviewed changes
src/ser.rs Show resolved Hide resolved
ma2bd
ma2bd approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@ma2bd ma2bd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zekun000, Thanks for the PR (and sorry for the delay). I'll give a chance for @bmwill to comment before making a release.

src/de.rs Outdated Show resolved Hide resolved
@zekun000
Copy link
Contributor Author

addressed comments

@ma2bd ma2bd merged commit 97bf218 into zefchain:main Feb 16, 2023
@ma2bd
Copy link
Contributor

ma2bd commented Feb 16, 2023

@zekun000 @bmwill The change was released in BCS v0.1.5

@ma2bd ma2bd mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ma2bd ma2bd ma2bd approved these changes

@bmwill bmwill bmwill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zekun000 @vgao1996 @ma2bd @bmwill